netdev - Re: [PATCH net] vrf: prevent adding upper devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3a132cac-91bc-a7ba-6ae0-dccf4898c1c7@gmail.com>
Date:   Tue, 26 Mar 2019 11:24:05 -0600
From:   David Ahern <dsahern@...il.com>
To:     Sabrina Dubroca <sd@...asysnail.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net] vrf: prevent adding upper devices

On 3/26/19 11:22 AM, Sabrina Dubroca wrote:
> VRF devices don't work with upper devices. Currently, it's possible to
> add a VRF device to a bridge or team, and to create macvlan, macsec, or
> ipvlan devices on top of a VRF (bond and vlan are prevented respectively
> by the lack of an ndo_set_mac_address op and the NETIF_F_VLAN_CHALLENGED
> feature flag).
> 
> Fix this by setting the IFF_NO_RX_HANDLER flag (introduced in commit
> f5426250a6ec ("net: introduce IFF_NO_RX_HANDLER")).
> 
> Cc: David Ahern <dsahern@...il.com>
> Fixes: 193125dbd8eb ("net: Introduce VRF device driver")
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>
> ---
>  drivers/net/vrf.c | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: David Ahern <dsahern@...il.com>

Thanks for diving into this.