netdev - Re: [PATCH net v2 0/2] thunderx: fix receive buffer page recycling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2bf5a8d9-3fec-28b5-ecb0-bba1fb88b2df@redhat.com>
Date:   Tue, 26 Mar 2019 12:24:06 -0500
From:   Dean Nelson <dnelson@...hat.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     Robert Richter <rric@...nel.org>,
        Sunil Goutham <sgoutham@...ium.com>,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Vadim Lomovtsev <vlomovtsev@...vell.com>
Subject: Re: [PATCH net v2 0/2] thunderx: fix receive buffer page recycling

On 3/26/19 11:18 AM, Jesper Dangaard Brouer wrote:
> On Tue, 26 Mar 2019 11:09:10 -0500
> Dean Nelson <dnelson@...hat.com> wrote:
> 
>> On 3/26/19 10:53 AM, Dean Nelson wrote:
>>> In attempting to optimize receive buffer page recycling for XDP, commit
>>> 773225388dae15e72790 ("net: thunderx: Optimize page recycling for XDP")
>>> inadvertently introduced two problems for the non-XDP case, that will be
>>> addressed by this patch series.
>>>
>>> Dean Nelson (2):
>>>     thunderx: enable page recycling for non-XDP case
>>>     thunderx: eliminate extra calls to put_page() for pages held for recycling
>>>
>>>    drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 30 ++++++++++++++----------------
>>>    1 file changed, 14 insertions(+), 16 deletions(-)
>>>    
>>
>>
>> I'm really sorry, I completely forgot to add a description
>> of what the changes were made by v2 (which was just to add
>> the 'Fixes:' lines to the changelogs).
> 
> That should be okay, for such a small change.

Okay.

>> And I forgot to add you to the CC-list. I'm assuming I
>> should repost? Right? (And do you want to be added?)
>>
>> It's just one of those days.
> 
> I can live with not getting Cc'ed (but I would prefer it), but some
> other adjustments.

By your phrase "but some other adjustments", are you indicating that
I should post a v3 with the below items addressed (and while I'm at
it fix the above two)? Or is the following just for my education for the
future?

> 
> There should not be a newline between "Fixes:" and "Signed-off-by:".

Good to know. I'd actually searched netdev mailing list for examples.
And the one patch I happened to look at, had a blank line separating it
and the "Signed-off-by:" line that followed. And just looking again, I
saw a couple that way. But they're definitely in the minority.

> And nitpicking, I believe that we usually only show the first 12 chars
> of the commit id.  I have setup git to use: 'git show --pretty=fixes'

I had looked at Documentation/process/submitting-patches.rst and had
read the following...

   If you want to refer to a specific commit, don't just refer to the
   SHA-1 ID of the commit. Please also include the oneline summary of
   the commit, to make it easier for reviewers to know what it is about.
   Example::

           Commit e21d2170f36602ae2708 ("video: remove unnecessary
           platform_set_drvdata()") removed the unnecessary
           platform_set_drvdata(), but left the variable "dev" unused,
           delete it.

   You should also be sure to use at least the first twelve characters 
of the
   SHA-1 ID.  The kernel repository holds a *lot* of objects, making
   collisions with shorter IDs a real possibility.  Bear in mind that, 
even if
   there is no collision with your six-character ID now, that condition may
   change five years from now.

Which has the first 20 chars in its example, and speaks of using at
least 12 chars.

So now I just went back and re-read that section and the paragraph that
followed it (which previously had been outside of the view of my
terminal window)...

   If your patch fixes a bug in a specific commit, e.g. you found an 
issue using
   ``git bisect``, please use the 'Fixes:' tag with the first 12 
characters of
   the SHA-1 ID, and the one line summary.  Do not split the tag across 
multiple
   lines, tags are exempt from the "wrap at 75 columns" rule in order to 
simplify
   parsing scripts.  For example::

           Fixes: 54a4f0239f2e ("KVM: MMU: make kvm_mmu_zap_page() 
return the number of pages it actually freed")

Which does say that you are correct. Just the first 12 chars should be
used.

Like I said earlier... just one of those days.  :-)

> 
>  From my ~/.gitconfig:
> ---------------------
> [core]
>          abbrev = 12
> 
> [pretty]
>          fixes = Fixes: %h (\"%s\")
> 
>