netdev - Re: [PATCH net v2 0/2] thunderx: fix receive buffer page recycling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 26 Mar 2019 17:18:44 +0100
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     Dean Nelson <dnelson@...hat.com>
Cc:     brouer@...hat.com, Robert Richter <rric@...nel.org>,
        Sunil Goutham <sgoutham@...ium.com>,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Vadim Lomovtsev <vlomovtsev@...vell.com>
Subject: Re: [PATCH net v2 0/2] thunderx: fix receive buffer page recycling

On Tue, 26 Mar 2019 11:09:10 -0500
Dean Nelson <dnelson@...hat.com> wrote:

> On 3/26/19 10:53 AM, Dean Nelson wrote:
> > In attempting to optimize receive buffer page recycling for XDP, commit
> > 773225388dae15e72790 ("net: thunderx: Optimize page recycling for XDP")
> > inadvertently introduced two problems for the non-XDP case, that will be
> > addressed by this patch series.
> > 
> > Dean Nelson (2):
> >    thunderx: enable page recycling for non-XDP case
> >    thunderx: eliminate extra calls to put_page() for pages held for recycling
> > 
> >   drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 30 ++++++++++++++----------------
> >   1 file changed, 14 insertions(+), 16 deletions(-)
> >   
> 
> 
> I'm really sorry, I completely forgot to add a description
> of what the changes were made by v2 (which was just to add
> the 'Fixes:' lines to the changelogs).

That should be okay, for such a small change.

> And I forgot to add you to the CC-list. I'm assuming I
> should repost? Right? (And do you want to be added?)
> 
> It's just one of those days.

I can live with not getting Cc'ed (but I would prefer it), but some
other adjustments.

There should not be a newline between "Fixes:" and "Signed-off-by:".
And nitpicking, I believe that we usually only show the first 12 chars
of the commit id.  I have setup git to use: 'git show --pretty=fixes'

>From my ~/.gitconfig:
---------------------
[core]
        abbrev = 12

[pretty]
        fixes = Fixes: %h (\"%s\")


-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer