netdev - Re: [PATCH v2] net: fjes: fix potential NULL pointer dereferences

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 26 Mar 2019 10:50:50 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     kjlu@....edu
Cc:     pakki001@....edu, colin.king@...onical.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: fjes: fix potential NULL pointer dereferences

From: Kangjie Lu <kjlu@....edu>
Date: Fri, 22 Mar 2019 22:52:21 -0500

> @@ -1252,8 +1252,16 @@ static int fjes_probe(struct platform_device *plat_dev)
>  	adapter->open_guard = false;
>  
>  	adapter->txrx_wq = alloc_workqueue(DRV_NAME "/txrx", WQ_MEM_RECLAIM, 0);
> +	if (!adapter->txrx_wq) {
> +		err = -ENOMEM;
> +		goto err_free_netdev;
> +	}

These error paths have to undo the netif_napi_add() done by fjes_sw_init().