netdev - Re: [RFC PATCH net-next 06/13] net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+h21hpJVD3Z_1VRKJ=v_tOCm3SuTYt2-Uy5QxHpO+=+gPgXDQ@mail.gmail.com>
Date:   Tue, 26 Mar 2019 19:52:44 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     davem@...emloft.net, netdev <netdev@...r.kernel.org>,
        Andrew Lunn <andrew@...n.ch>, vivien.didelot@...il.com,
        Linus Walleij <linus.walleij@...aro.org>,
        Georg Waibel <georg.waibel@...sor-technik.de>
Subject: Re: [RFC PATCH net-next 06/13] net: dsa: Introduce driver for NXP
 SJA1105 5-port L2 switch

Hi Florian,

I am grateful for the thorough review you made to the entire patchset.
It's nice to meet passionate people whom I can share ideas with.

On Tue, 26 Mar 2019 at 15:02, Florian Fainelli <f.fainelli@...il.com> wrote:
> On 3/23/2019 8:23 PM, Vladimir Oltean wrote:
> > At this moment the following is supported:
> > * Link state management through phylib
>
> Not a show stopper for now, and your implementation looks sane, though I
> would recommend implementing phylink to be future proof, and especially
> since you support SGMII.
>
> I was not able to review everything deeply so:
>
> Acked-by: Florian Fainelli <f.fainelli@...il.com>
> --
> Florian

I don't think SGMII works at this point, with the current enablement.
When I send the first non-RFC patchset I think I'm going to completely
remove it (along with some other momentarily unused code). I'll add it
back when I can put my hands on a board where the SGMII interface is
actually routed - hopefully in a few weeks at most. Then I can also
rework the MAC adaptation to PHY portion to use phylink instead of
phylib, for "future-proofing".

Thank you!
-Vladimir