netdev - Re: [PATCH net] net: phy: don't clear BMCR in genphy_soft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190325.170929.2240397133766757467.davem@davemloft.net>
Date:   Mon, 25 Mar 2019 17:09:29 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org,
        preid@...ctromag.com.au, liweihang@...ilicon.com
Subject: Re: [PATCH net] net: phy: don't clear BMCR in genphy_soft_reset

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Fri, 22 Mar 2019 20:00:20 +0100

> So far we effectively clear the BMCR register. Some PHY's can deal
> with this (e.g. because they reset BMCR to a default as part of a
> soft-reset) whilst on others this causes issues because e.g. the
> autoneg bit is cleared. Marvell is an example, see also thread [0].
> So let's be a little bit more gentle and leave all bits we're not
> interested in as-is. This change is needed for PHY drivers to
> properly deal with the original patch.
> 
> [0] https://marc.info/?t=155264050700001&r=1&w=2
> 
> Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
> Tested-by: Phil Reid <preid@...ctromag.com.au>
> Tested-by: liweihang <liweihang@...ilicon.com>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied and queued up for -stable, thanks.