netdev - Re: [RFC PATCH net-next 09/13] net: dsa: sja1105: Add support for ethtool port counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <550b2928-3c35-5e61-9d90-668a165da8ff@gmail.com>
Date:   Mon, 25 Mar 2019 19:44:37 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>, davem@...emloft.net,
        netdev@...r.kernel.org
Cc:     andrew@...n.ch, vivien.didelot@...il.com, linus.walleij@...aro.org
Subject: Re: [RFC PATCH net-next 09/13] net: dsa: sja1105: Add support for
 ethtool port counters



On 3/23/2019 8:23 PM, Vladimir Oltean wrote:
> Signed-off-by: Vladimir Oltean <olteanv@...il.com>
> ---

[snip]

> +
> +int sja1105_get_sset_count(struct dsa_switch *ds, int port, int sset)
> +{
> +	int count = ARRAY_SIZE(sja1105_port_stats);
> +	struct sja1105_private *priv = ds->priv;

There is a missing if (sset != ETH_SS_STATS) return here potentially.
With that:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian