netdev - Re: [PATCH mlx5-next 3/4] net/mlx5: Decrease default mr cache size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Mar 2019 13:58:17 +0200
From:   Or Gerlitz <gerlitz.or@...il.com>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...lanox.com>,
        RDMA mailing list <linux-rdma@...r.kernel.org>,
        Artemy Kovalyov <artemyko@...lanox.com>,
        Guy Levi <guyle@...lanox.com>,
        Haggai Eran <haggaie@...lanox.com>,
        Jerome Glisse <jglisse@...hat.com>,
        Moni Shoua <monis@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        linux-netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH mlx5-next 3/4] net/mlx5: Decrease default mr cache size

On Wed, Mar 27, 2019 at 1:41 PM Leon Romanovsky <leon@...nel.org> wrote:
> On Wed, Mar 27, 2019 at 12:07:54PM +0200, Or Gerlitz wrote:
> > On Tue, Mar 19, 2019 at 11:25 AM Leon Romanovsky <leon@...nel.org> wrote:
> > > From: Artemy Kovalyov <artemyko@...lanox.com>
> > >
> > > Delete initialization of high order entries in mr cache to decrease initial
> > > memory footprint. When required, the administrator can populate the
> > > entries with memory keys via the /sys interface.
> >
> > Please add here:
> >
> > This approach is very helpful to reduce the per HW function memory
> > footprint in environments such as VMs. Before the patch we see
> > consumption of 0.9GB per function and after the patch about 0.1GB
> >
> > > Signed-off-by: Artemy Kovalyov <artemyko@...lanox.com>
> > > Signed-off-by: Moni Shoua <monis@...lanox.com>
> > > Signed-off-by: Leon Romanovsky <leonro@...lanox.com>
> >
> > Reported-by:  Shalom Toledo <shalomt@...lanox.com>
> > Acked-by: Or Gerlitz <ogerlitz@...lanox.com>
> >
> > Lets push it into stable kernels, a Fixes tag here will cause that
> > to happen more easily, so please consider that.

> I'll add it at the "apply" stage.

Just to make sure, by "add it" you mean the signatures, the text and
the Fixes that?

Also, is there any reason not to eliminate the mr cache pre-population
all together?

Currently we consume 100-200MB per function after the patch which is
also problematic for some
environments.