netdev - Re: [PATCH net-next] dpaa2-eth: use netif_receive_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab5c0620-e861-5921-dfed-7a30a51d369b@solarflare.com>
Date:   Wed, 27 Mar 2019 12:02:13 +0000
From:   Edward Cree <ecree@...arflare.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>,
        Ioana Ciornei <ioana.ciornei@....com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Ioana Ciocoi Radulescu <ruxandra.radulescu@....com>,
        Florian Westphal <fw@...len.de>
Subject: Re: [PATCH net-next] dpaa2-eth: use netif_receive_skb_list

On 26/03/2019 14:43, Jesper Dangaard Brouer wrote:
> On Mon, 25 Mar 2019 13:42:39 +0000
> Ioana Ciornei <ioana.ciornei@....com> wrote:
>
>> Take advantage of the software Rx batching by using
>> netif_receive_skb_list instead of napi_gro_receive.
>>
>> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
>> ---
> Nice to see more people/drivers using: netif_receive_skb_list()
>
> We should likely add a similar napi_gro_receive_list() function.
I had a patch series that did that; last posting was v3 back in
November: https://marc.info/?l=linux-netdev&m=154221888012410&w=2
However, Eric raised some issues, also some Mellanox folks privately
reported that using it in their driver regressed performance, and
I've been too busy since to make progress with it.  Since you seem
to be much better than me at perf investigations, Jesper, maybe you
could take over the series?

-Ed