netdev - Re: [PATCH net-next 03/13] ipv4: Create init helper for fib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Mar 2019 08:17:26 -0600
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...lanox.com>,
        David Ahern <dsahern@...nel.org>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>
Subject: Re: [PATCH net-next 03/13] ipv4: Create init helper for fib_nh

On 3/27/19 2:12 AM, Ido Schimmel wrote:
> On Tue, Mar 26, 2019 at 08:29:32PM -0700, David Ahern wrote:
>> +int fib_nh_init(struct net *net, struct fib_nh *nh,
>> +		struct fib_config *cfg, int nh_weight,
>> +		struct netlink_ext_ack *extack)
>> +{
>> +	int err = -ENOMEM;
>> +
>> +	nh->nh_pcpu_rth_output = alloc_percpu(struct rtable __rcu *);
>> +	if (!nh->nh_pcpu_rth_output)
>> +		goto failure;
>> +
>> +	if (cfg->fc_encap) {
>> +		struct lwtunnel_state *lwtstate;
>> +
>> +		err = -EINVAL;
>> +		if (cfg->fc_encap_type == LWTUNNEL_ENCAP_NONE) {
>> +			NL_SET_ERR_MSG(extack, "LWT encap type not specified");
>> +			goto failure;
> 
> This is very confusing and probably error-prone. You call
> alloc_percpu(), but don't free it in the error path and instead rely on
> the call to free_fib_info() in the error path of fib_create_info().
> Better to free it here and NULL-ify the pointer. Then the call to
> rt_fibinfo_free_cpus() in free_fib_info_rcu() is basically a NOP.
> 

Sure. I will change it.