netdev - Re: [PATCH net-next 06/13] ipv6: Create cleanup helper for fib6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7023167f-b20b-794b-477c-391c2abff2d8@gmail.com>
Date:   Wed, 27 Mar 2019 08:17:59 -0600
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...lanox.com>,
        David Ahern <dsahern@...nel.org>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>
Subject: Re: [PATCH net-next 06/13] ipv6: Create cleanup helper for fib6_nh

On 3/27/19 2:38 AM, Ido Schimmel wrote:
> Why did you flip the order?
> 
> lwtstate_put()
> dev_put()
> 
> is symmetric with fib6_nh_init()

no real reason. Will reverse them