netdev - Re: [PATCH net-next v5 19/22] ethtool: provide WoL information in GET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Mar 2019 20:42:26 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Michal Kubecek <mkubecek@...e.cz>,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Cc:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Jiri Pirko <jiri@...nulli.us>, Andrew Lunn <andrew@...n.ch>,
        John Linville <linville@...driver.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v5 19/22] ethtool: provide WoL information in
 GET_SETTINGS request



On 3/25/2019 10:08 AM, Michal Kubecek wrote:
> Add information about supported and enabled wake on LAN modes into the
> GET_SETTINGS reply when ETH_SETTINGS_IM_WOL flag is set in the request.
> 
> The GET_SETTINGS request can be still sent by unprivileged users but in
> such case the SecureOn password (if any) is not included in the reply.
> 
> Send notification in the same format as reply SET_SETTINGS message when
> wake on LAN settings are modified using ioctl interface (ETHTOOL_SWOL
> command).

Looks good to me, just one question below:

> 
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>
> ---

[snip]
>  
> +	data->privileged = ethnl_is_privileged(skb);

Is not this potentially creating a time of check/time of use issue? Can
you check for ethnl_is_privileged() at the time where you fill in the
reply skb?
-- 
Florian