netdev - Re: [PATCH net-next v5 16/22] ethtool: provide link settings and link modes in GET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8fe118a8-2a51-5740-de68-300f52a81861@gmail.com>
Date:   Wed, 27 Mar 2019 20:44:58 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Michal Kubecek <mkubecek@...e.cz>,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Cc:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Jiri Pirko <jiri@...nulli.us>, Andrew Lunn <andrew@...n.ch>,
        John Linville <linville@...driver.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v5 16/22] ethtool: provide link settings and link
 modes in GET_SETTINGS request



On 3/25/2019 10:08 AM, Michal Kubecek wrote:
> Implement GET_SETTINGS netlink request to get link settings and link mode
> information provided by ETHTOOL_GLINKSETTINGS ioctl command.
> 
> The information in SET_SETTINGS message sent as reply is divided into two
> parts: autonegotiation, speed, duplex and supported, advertised and peer
> advertised link modes when ETH_SETTINGS_IM_LINKMODES flag is set in the
> request and other settings when ETH_SETTINGS_IM_LINKINFO is set.
> 
> Send notification in the same format as the reply message when relevant
> fields are modified using the ioctl interface (ETHTOOL_SLINKSETTINGS or
> ETHTOOL_SSET command).
> 
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>
> ---

[snip]

> +    ETHA_SETTINGS_DEV		(nested)	device identification
> +    ETHA_SETTINGS_LINK_INFO	(nested)	link settings
> +        ETHA_LINKINFO_PORT		(u8)		physical port
> +        ETHA_LINKINFO_PHYADDR		(u8)		MDIO address of phy
> +        ETHA_LINKINFO_TP_MDIX		(u8)		MDI(-X) status
> +        ETHA_LINKINFO_TP_MDIX_CTRL	(u8)		MDI(-X) control
> +        ETHA_LINKINFO_TRANSCEIVER	(u8)		transceiver
> +    ETHA_SETTINGS_LINK_MODES	(nested)	link modes
> +        ETHA_LINKMODES_AUTONEG		(u8)		autoneotiation status

Typo: auto-negotiation status.
-- 
Florian