lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CADRPPNQ9AGRvq8XDjeTerUBry+_hO-U=shCXFaqHhtc9QvMvng@mail.gmail.com> Date: Fri, 29 Mar 2019 16:50:23 -0500 From: Li Yang <leoyang.li@....com> To: Laurentiu Tudor <laurentiu.tudor@....com> Cc: Netdev <netdev@...r.kernel.org>, madalin.bucur@....com, Roy Pledge <roy.pledge@....com>, camelia.groza@....com, David Miller <davem@...emloft.net>, Linux IOMMU <iommu@...ts.linux-foundation.org>, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>, linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>, lkml <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 01/13] soc/fsl/qman: fixup liodns only on ppc targets On Fri, Mar 29, 2019 at 9:01 AM <laurentiu.tudor@....com> wrote: > > From: Laurentiu Tudor <laurentiu.tudor@....com> > > ARM SoCs use SMMU so the liodn fixup done in the qman driver is no > longer making sense and it also breaks the ICID settings inherited > from u-boot. Do the fixups only for PPC targets. > > Signed-off-by: Laurentiu Tudor <laurentiu.tudor@....com> > --- > drivers/soc/fsl/qbman/qman_ccsr.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/soc/fsl/qbman/qman_ccsr.c b/drivers/soc/fsl/qbman/qman_ccsr.c > index 109b38de3176..12e414ca3b03 100644 > --- a/drivers/soc/fsl/qbman/qman_ccsr.c > +++ b/drivers/soc/fsl/qbman/qman_ccsr.c > @@ -598,6 +598,7 @@ static int qman_init_ccsr(struct device *dev) > #define LIO_CFG_LIODN_MASK 0x0fff0000 > void qman_liodn_fixup(u16 channel) > { > +#ifdef CONFIG_PPC > static int done; > static u32 liodn_offset; > u32 before, after; > @@ -617,6 +618,7 @@ void qman_liodn_fixup(u16 channel) > qm_ccsr_out(REG_REV3_QCSP_LIO_CFG(idx), after); > else > qm_ccsr_out(REG_QCSP_LIO_CFG(idx), after); > +#endif According to the Linux coding style recommendation, it would be better to put the #ifdef into the header files "drivers/soc/fsl/qbman/qman_priv.h". And I'm not sure if this is needed on PPC when IOMMU(PAMU) driver is not compiled, if not, probably using CONFIG_PAMU as condition would be even better. > } > > #define IO_CFG_SDEST_MASK 0x00ff0000 > -- > 2.17.1 >
Powered by blists - more mailing lists