netdev - Re: [PATCH ipsec-next 03/11] xfrm: remove input indirection from xfrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190329171934.5t63zm6slyjdyfpf@breakpoint.cc>
Date:   Fri, 29 Mar 2019 18:19:34 +0100
From:   Florian Westphal <fw@...len.de>
To:     Eyal Birger <eyal.birger@...il.com>
Cc:     Florian Westphal <fw@...len.de>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Steffen Klassert <steffen.klassert@...unet.com>
Subject: Re: [PATCH ipsec-next 03/11] xfrm: remove input indirection from
 xfrm_mode

Eyal Birger <eyal.birger@...il.com> wrote:
> > diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c
> > index ea5ac053c15d..e3c7edd11e77 100644
> > --- a/net/xfrm/xfrm_input.c
> > +++ b/net/xfrm/xfrm_input.c
> > @@ -186,6 +186,74 @@ int xfrm_prepare_input(struct xfrm_state *x, struct sk_buff *skb)
> >  }
> >  EXPORT_SYMBOL(xfrm_prepare_input);
> 
> nit: looks like xfrm_prepare_input() should be static now, no?

Indeed, I've fixed this up, thanks Eyal.