netdev - Re: [PATCH v3 net-next 00/13] net: Move fib_nh and fib6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190329.105314.682397988670279152.davem@davemloft.net>
Date:   Fri, 29 Mar 2019 10:53:14 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...nel.org
Cc:     netdev@...r.kernel.org, idosch@...lanox.com, jiri@...lanox.com,
        saeedm@...lanox.com, dsahern@...il.com
Subject: Re: [PATCH v3 net-next 00/13] net: Move fib_nh and fib6_nh to a
 common struct

From: David Ahern <dsahern@...nel.org>
Date: Wed, 27 Mar 2019 20:53:45 -0700

> From: David Ahern <dsahern@...il.com>
> 
> First set of three with the end goal of enabling IPv6 gateways with IPv4
> routes.
> 
> This set refactors ipv4 and ipv6 code to create init and release
> helpers for each protocol and moving common elements to a fib_nh_common
> struct.
> 
> v3
> - split the reject setting into 2 with helper to the checks. This
>   avoids changing cfg->fc_flags in fib6_nh_init
> 
> v2
> - addressed Ido's comments: cleanup on failure path in nh_init helpers,
>   ordering in fib6_nh_release, and removal of RTF_GATEWAY from fib6_info
>   uses in mlxsw

Looks great, series applied, thanks David.