netdev - Re: [PATCH v3 net-next 13/13] net: Use common nexthop init and release helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1197eb44-5539-c35d-19ee-fc0c7503d1b8@gmail.com>
Date:   Thu, 28 Mar 2019 12:10:22 -0600
From:   David Ahern <dsahern@...il.com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        David Ahern <dsahern@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, idosch@...lanox.com,
        jiri@...lanox.com, saeedm@...lanox.com
Subject: Re: [PATCH v3 net-next 13/13] net: Use common nexthop init and
 release helpers

On 3/28/19 9:50 AM, Alexei Starovoitov wrote:
> 
> patch 5 isn't pretty still and you didn't answer my question
> why pointer to fib6_flags is worse than duplicated check.

fib6_flags (prefix flags) has nothing to do with a fib6_nh
initialization, and I do want to add a 6th input argument for something
that is used in only 1 of 2 paths and even the 1 path is a highly unlikely.