netdev - Re: [PATCH net] net/sched: fix ->get helper of the matchall cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190401.141309.1277998702086618249.davem@davemloft.net>
Date:   Mon, 01 Apr 2019 14:13:09 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     nicolas.dichtel@...nd.com
Cc:     netdev@...r.kernel.org, yotamg@...lanox.com, jiri@...lanox.com
Subject: Re: [PATCH net] net/sched: fix ->get helper of the matchall cls

From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
Date: Thu, 28 Mar 2019 10:35:06 +0100

> It returned always NULL, thus it was never possible to get the filter.
> 
> Example:
> $ ip link add foo type dummy
> $ ip link add bar type dummy
> $ tc qdisc add dev foo clsact
> $ tc filter add dev foo protocol all pref 1 ingress handle 1234 \
> 	matchall action mirred ingress mirror dev bar
> 
> Before the patch:
> $ tc filter get dev foo protocol all pref 1 ingress handle 1234 matchall
> Error: Specified filter handle not found.
> We have an error talking to the kernel
> 
> After:
> $ tc filter get dev foo protocol all pref 1 ingress handle 1234 matchall
> filter ingress protocol all pref 1 matchall chain 0 handle 0x4d2
>   not_in_hw
>         action order 1: mirred (Ingress Mirror to device bar) pipe
>         index 1 ref 1 bind 1
> 
> CC: Yotam Gigi <yotamg@...lanox.com>
> CC: Jiri Pirko <jiri@...lanox.com>
> Fixes: fd62d9f5c575 ("net/sched: matchall: Fix configuration race")
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

I'll apply this and queue it up for -stable, but we really should add
a testcase to selftests for this if we don't have one already.