netdev - Re: [PATCH net-next] r8169: use netif_receive_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 1 Apr 2019 14:33:21 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     David Miller <davem@...emloft.net>, brouer@...hat.com
Cc:     eric.dumazet@...il.com, hkallweit1@...il.com, nic_swsd@...ltek.com,
        netdev@...r.kernel.org, ecree@...arflare.com
Subject: Re: [PATCH net-next] r8169: use netif_receive_skb_list batching



On 04/01/2019 10:41 AM, David Miller wrote:
> From: Jesper Dangaard Brouer <brouer@...hat.com>
>>
>> As Eric says, this in-effect disables GRO for this driver.
> 
> Really?  __netif_receive_skb_list_core() does GRO.

At least on current public trees, it can not do GRO,
since we do not pass a napi context.