netdev - Re: net: fix routing encapsulated packets when binding a socket to a tunnel interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6c73524bdddc66f9959243a5a4ce2827@synology.com>
Date:   Mon, 01 Apr 2019 17:52:34 +0800
From:   lifonghsu <lifonghsu@...ology.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: net: fix routing encapsulated packets when binding a socket to a
 tunnel interface

David Miller 於 2019-04-01 14:01 寫到:
> From: lifonghsu <lifonghsu@...ology.com>
> Date: Mon, 01 Apr 2019 11:00:22 +0800
> 
>> Since we are not sure whether there is any code referring to the
>> value of skb_iff in transmit site or not, it is risky to set an
>> invalid interface
> 
> If you are no confident in how the value is used on TX, then I can't
> consider your change with confidence either.
> 
> Think about what you are saying to me here.  You basically do not know
> whether you are adding a bug or not.

Indeed, we are not confident about the commit. Please drop it for now.
Thank you for help review the commit.