netdev - Re: [PATCH v3 net-next 3/5] ipv4: Refactor nexthop attributes in fib_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190402171054.aswpgcymtmxwwxz5@kafai-mbp.dhcp.thefacebook.com>
Date:   Tue, 2 Apr 2019 17:10:57 +0000
From:   Martin Lau <kafai@...com>
To:     David Ahern <dsahern@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "idosch@...lanox.com" <idosch@...lanox.com>,
        "David Ahern" <dsahern@...il.com>
Subject: Re: [PATCH v3 net-next 3/5] ipv4: Refactor nexthop attributes in
 fib_dump_info

On Mon, Apr 01, 2019 at 08:02:32PM -0700, David Ahern wrote:
> From: David Ahern <dsahern@...il.com>
> 
> Similar to ipv6, move addition of nexthop attributes to dump
> message into helpers that are called for both single path and
> multipath routes. Align the new helpers to the IPv6 variant
> which most notably means computing the flags argument based on
> settings in nh_flags.
> 
> The RTA_FLOW argument is unique to IPv4, so it is appended after
> the new fib_nexthop_info helper. The intent of a later patch is to
> make both fib_nexthop_info and fib_add_nexthop usable for both IPv4
> and IPv6. This patch is stepping stone in that direction.
Acked-by: Martin KaFai Lau <kafai@...com>