netdev - Re: [PATCH v3 net-next 4/5] ipv4: Change fib_nexthop_info and fib_add_nexthop to take fib_nh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190402171124.wnanzwqpddesykxx@kafai-mbp.dhcp.thefacebook.com>
Date:   Tue, 2 Apr 2019 17:11:27 +0000
From:   Martin Lau <kafai@...com>
To:     unlisted-recipients:; (no To-header on input)
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "idosch@...lanox.com" <idosch@...lanox.com>,
        "David Ahern" <dsahern@...il.com>
Subject: Re: [PATCH v3 net-next 4/5] ipv4: Change fib_nexthop_info and
 fib_add_nexthop to take fib_nh_common

On Mon, Apr 01, 2019 at 08:02:33PM -0700, David Ahern wrote:
> From: David Ahern <dsahern@...il.com>
> 
> With the exception of the nexthop weight, the nexthop attributes used by
> fib_nexthop_info and fib_add_nexthop come from the fib_nh_common struct.
> Update both to use it and change fib_nexthop_info to check the family
> as needed.
> 
> nexthop weight comes from the common struct for existing use cases, but
> for nexthop groups the weight is outside of the fib_nh_common to allow
> the same nexthop definition to be used in multiple groups with different
> weights.
Acked-by: Martin KaFai Lau <kafai@...com>