netdev - Re: [PATCH net-next] net: phy: improve genphy_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6c6effbc-366a-3082-a857-115ba94d069f@gmail.com>
Date:   Tue, 2 Apr 2019 19:39:28 +0200
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: phy: improve genphy_read_status

On 31.03.2019 17:05, Heiner Kallweit wrote:
> On 31.03.2019 16:58, Andrew Lunn wrote:
>>> - In auto-neg case, skip populating lp_advertising if we
>>>   don't have a link. This avoids quite some unnecessary
>>>   MDIO reads in case of phylib polling mode.
>>
>> Hi Heiner
>>
>> Could it be that we don't have a link because what the partner is
>> advertising does not intersect with what we are advertising?
>>
> Interesting point. Yes, I think I missed that scenario.
> 
Just saw that Dave applied this patch. So I will send a fix to deal
with this scenario properly.

>> Hence knowing what it is adverting is actually useful in this case?
>>
>>       Andrew
>>
> Heiner
>