lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 01 Apr 2019 18:07:13 -0700 (PDT) From: David Miller <davem@...emloft.net> To: hkallweit1@...il.com Cc: andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org Subject: Re: [PATCH net-next] net: phy: improve genphy_read_status From: Heiner Kallweit <hkallweit1@...il.com> Date: Sat, 30 Mar 2019 10:22:45 +0100 > This patch improves few aspects of genphy_read_status(): > > - Don't initialize lpagb, it's not needed. > > - Move initializing phydev->speed et al before the if clause. > > - In auto-neg case, skip populating lp_advertising if we > don't have a link. This avoids quite some unnecessary > MDIO reads in case of phylib polling mode. > > Signed-off-by: Heiner Kallweit <hkallweit1@...il.com> I decided that I'm not going to push back on this patch purely on the issue of not touching the conditional ordering. Applied, thanks Heiner.
Powered by blists - more mailing lists