netdev - Re: [PATCH] net-gro: Fix GRO flush when receiving a GSO packet.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 Apr 2019 12:32:53 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Steffen Klassert <steffen.klassert@...unet.com>,
        David Miller <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] net-gro: Fix GRO flush when receiving a GSO packet.

Hello!

On 02.04.2019 9:16, Steffen Klassert wrote:

> Currently we may merge incorrectly a received GSO packet
> or a packet with frag_list into a packet sitting in the
> gro_hash list. skb_segment() may crash in this case because
> the assumptions on the skb layout are not met in this case.

    "In this case" repeated twice in the same sentence sounds
somewhat tautological. :-)

> The correct behaviour would be to flush the packet in the
> gro_hash list and send the received GSO packet directly
> afterwards. Commit d61d072e87c8e ("net-gro: avoid reorders")
> sets NAPI_GRO_CB(skb)->flush in this case, but this is not
> checked before merging. This patch makes sure to check this
> flag and to not merge in that case.
> 
> Fixes: d61d072e87c8e ("net-gro: avoid reorders")
> Signed-off-by: Steffen Klassert <steffen.klassert@...unet.com>
[...]

MBR, Sergei