netdev - Re: [PATCH] net-gro: Fix GRO flush when receiving a GSO packet.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190403.214131.1081946013901750428.davem@davemloft.net>
Date:   Wed, 03 Apr 2019 21:41:31 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     steffen.klassert@...unet.com
Cc:     edumazet@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net-gro: Fix GRO flush when receiving a GSO packet.

From: Steffen Klassert <steffen.klassert@...unet.com>
Date: Tue, 2 Apr 2019 08:16:03 +0200

> Currently we may merge incorrectly a received GSO packet
> or a packet with frag_list into a packet sitting in the
> gro_hash list. skb_segment() may crash in this case because
> the assumptions on the skb layout are not met in this case.
> The correct behaviour would be to flush the packet in the
> gro_hash list and send the received GSO packet directly
> afterwards. Commit d61d072e87c8e ("net-gro: avoid reorders")
> sets NAPI_GRO_CB(skb)->flush in this case, but this is not
> checked before merging. This patch makes sure to check this
> flag and to not merge in that case.
> 
> Fixes: d61d072e87c8e ("net-gro: avoid reorders")
> Signed-off-by: Steffen Klassert <steffen.klassert@...unet.com>

Applied and queued up for -stable, thanks.