netdev - Re: [PATCH net-next 2/2] net: phy: deal properly with autoneg incomplete in genphy_c45_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190402135624.GB18443@lunn.ch>
Date:   Tue, 2 Apr 2019 15:56:24 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/2] net: phy: deal properly with autoneg
 incomplete in genphy_c45_read_lpa

On Sun, Mar 31, 2019 at 07:54:07PM +0200, Heiner Kallweit wrote:
> The link partner advertisement registers are not guaranteed to contain
> valid values if autoneg is incomplete. Therefore, if
> MDIO_AN_STAT1_COMPLETE isn't set, let's clear all link partner
> capability bits. This also avoids unnecessary register reads if link
> is down and phylib is in polling mode.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew