netdev - Re: [PATCH net-next 1/2] net: phy: use c45 standard to detect link partner autoneg capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190402135637.GC18443@lunn.ch>
Date:   Tue, 2 Apr 2019 15:56:37 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/2] net: phy: use c45 standard to detect link
 partner autoneg capability

On Sun, Mar 31, 2019 at 07:52:51PM +0200, Heiner Kallweit wrote:
> Currently mii_lpa_mod_linkmode_lpa_t() checks bit LPA_LPACK to detect
> whether link partner supports autoneg. This doesn't work correctly at
> least on Aquantia AQCS109 when it negotiates 1000Base-T2 mode.
> The "link partner is autoneg-capable" bit as defined by clause 45 is
> set however. Better let's switch in general to use the clause 45
> standard for link partner autoneg detection.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew