[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <af569c49-7131-dd06-bd2e-df100a11d4f9@solarflare.com>
Date: Wed, 3 Apr 2019 21:24:24 +0100
From: Edward Cree <ecree@...arflare.com>
To: Alexei Starovoitov <alexei.starovoitov@...il.com>
CC: Daniel Borkmann <daniel@...earbox.net>,
Paul Chaignon <paul.chaignon@...nge.com>,
Alexei Starovoitov <ast@...nel.org>, <netdev@...r.kernel.org>,
<bpf@...r.kernel.org>, Xiao Han <xiao.han@...nge.com>,
<paul.chaignon@...il.com>, Martin KaFai Lau <kafai@...com>,
Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>
Subject: Re: [PATCH bpf] bpf: report verifier bugs as warnings
On 03/04/2019 18:30, Alexei Starovoitov wrote:
> verbose_and_warn() doesn't fit these two practical cases of warn + verbose.
> Hence I see no reason to combine warn and verbose into single helper.
> They're perfectly fine being separate.
Makes sense.
So presumably the right patch would be to add more appropriate (concise
and less context-dependent) WARN messages alongside the verbose()s that
Paul's patch changed?
Powered by blists - more mailing lists