netdev - Re: [PATCH net-next] net: use correct this_cpu primitive in dev_recursion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <417c82a9-1a53-4a2a-68ee-4e52552a8a6d@gmail.com>
Date:   Wed, 3 Apr 2019 05:18:28 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Florian Westphal <fw@...len.de>, netdev@...r.kernel.org
Cc:     syzbot+51471b4aae195285a4a3@...kaller.appspotmail.com
Subject: Re: [PATCH net-next] net: use correct this_cpu primitive in
 dev_recursion_level



On 04/02/2019 11:28 PM, Florian Westphal wrote:
> syzbot reports:
> BUG: using __this_cpu_read() in preemptible code:
> caller is dev_recursion_level include/linux/netdevice.h:3052 [inline]
>  __this_cpu_preempt_check+0x246/0x270 lib/smp_processor_id.c:47
>  dev_recursion_level include/linux/netdevice.h:3052 [inline]
>  ip6_skb_dst_mtu include/net/ip6_route.h:245 [inline]
> 
> I erronously downgraded a this_cpu_read to __this_cpu_read when
> moving dev_recursion_level() around.
> 

Reviewed-by: Eric Dumazet <edumazet@...gle.com>