netdev - Re: [PATCH net-next] net: use correct this_cpu primitive in dev_recursion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190404.173512.1788389432410305533.davem@davemloft.net>
Date:   Thu, 04 Apr 2019 17:35:12 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     fw@...len.de
Cc:     netdev@...r.kernel.org,
        syzbot+51471b4aae195285a4a3@...kaller.appspotmail.com
Subject: Re: [PATCH net-next] net: use correct this_cpu primitive in
 dev_recursion_level

From: Florian Westphal <fw@...len.de>
Date: Wed,  3 Apr 2019 08:28:35 +0200

> syzbot reports:
> BUG: using __this_cpu_read() in preemptible code:
> caller is dev_recursion_level include/linux/netdevice.h:3052 [inline]
>  __this_cpu_preempt_check+0x246/0x270 lib/smp_processor_id.c:47
>  dev_recursion_level include/linux/netdevice.h:3052 [inline]
>  ip6_skb_dst_mtu include/net/ip6_route.h:245 [inline]
> 
> I erronously downgraded a this_cpu_read to __this_cpu_read when
> moving dev_recursion_level() around.
> 
> Reported-by: syzbot+51471b4aae195285a4a3@...kaller.appspotmail.com
> Fixes: 97cdcf37b57e ("net: place xmit recursion in softnet data")
> Signed-off-by: Florian Westphal <fw@...len.de>

Applied, thanks Florian.