netdev - Re: [PATCH 0/6] stricter netlink validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db599b6b-94a5-3123-5613-9e349fcee702@cumulusnetworks.com>
Date:   Thu, 4 Apr 2019 20:44:25 -0600
From:   David Ahern <dsa@...ulusnetworks.com>
To:     David Miller <davem@...emloft.net>, johannes@...solutions.net
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        pablo@...filter.org
Subject: Re: [PATCH 0/6] stricter netlink validation

On 4/4/19 11:28 AM, David Miller wrote:
> From: Johannes Berg <johannes@...solutions.net>
> Date: Thu,  4 Apr 2019 08:54:02 +0200
> 
>> Here's a version that has passed build testing ;-)
> 
> :-)
> 
> I really like the approach taken here, and done in such a way that
> new attributes added get strict checking by default.
> 
> I'll let David Ahern et al. have time to review this.
> 

Hit a compile issue right out of the gate:

$ make O=kbuild/perf -j 24 -s
/home/dsa/kernel-2.git/net/openvswitch/flow_netlink.c: In function
‘validate_and_copy_check_pkt_len’:
/home/dsa/kernel-2.git/net/openvswitch/flow_netlink.c:2887:8: error:
implicit declaration of function ‘nla_parse_deprecated_strict’
[-Werror=implicit-function-declaration]
  err = nla_parse_deprecated_strict(a, OVS_CHECK_PKT_LEN_ATTR_MAX,
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~

You should do an allmodconfig build to check for any others. I disabled
ovs to continue.