netdev - Re: [PATCH 0/6] stricter netlink validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <282a621c0a0cc86787901d8ce96068b2ca680d0a.camel@sipsolutions.net>
Date:   Fri, 05 Apr 2019 09:09:32 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     David Ahern <dsa@...ulusnetworks.com>,
        David Miller <davem@...emloft.net>
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        pablo@...filter.org
Subject: Re: [PATCH 0/6] stricter netlink validation

On Thu, 2019-04-04 at 20:44 -0600, David Ahern wrote:
> Hit a compile issue right out of the gate:
> 
> $ make O=kbuild/perf -j 24 -s
> /home/dsa/kernel-2.git/net/openvswitch/flow_netlink.c: In function
> ‘validate_and_copy_check_pkt_len’:
> /home/dsa/kernel-2.git/net/openvswitch/flow_netlink.c:2887:8: error:
> implicit declaration of function ‘nla_parse_deprecated_strict’
> [-Werror=implicit-function-declaration]
>   err = nla_parse_deprecated_strict(a, OVS_CHECK_PKT_LEN_ATTR_MAX,
>         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> You should do an allmodconfig build to check for any others. I disabled
> ovs to continue.

Ugh, yes. The one change I made because I rebased on the latest net-next 
after the build testing ...

Sorry about that, I'll fix it in v2 after more reviews.

johannes