netdev - Re: [PATCH] vlan: conditional inclusion of FCoE hooks to match netdevice.h and bnx2x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190404.171851.2300207178008312076.davem@davemloft.net>
Date:   Thu, 04 Apr 2019 17:18:51 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     cleech@...hat.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] vlan: conditional inclusion of FCoE hooks to match
 netdevice.h and bnx2x

From: Chris Leech <cleech@...hat.com>
Date: Tue,  2 Apr 2019 15:06:12 -0700

> Way back in 3c9c36bcedd426f2be2826da43e5163de61735f7 the
> ndo_fcoe_get_wwn pointer was switched from depending on CONFIG_FCOE to
> CONFIG_LIBFCOE in order to allow building FCoE support into the bnx2x
> driver and used by bnx2fc without including the generic software fcoe
> module.
> 
> But, FCoE is generally used over an 802.1q VLAN, and the implementation
> of ndo_fcoe_get_wwn in the 8021q module was not similarly changed.  The
> result is that if CONFIG_FCOE is disabled, then bnz2fc cannot make a
> call to ndo_fcoe_get_wwn through the 8021q interface to the underlying
> bnx2x interface.  The bnx2fc driver then falls back to a potentially
> different mapping of Ethernet MAC to Fibre Channel WWN, creating an
> incompatibility with the fabric and target configurations when compared
> to the WWNs used by pre-boot firmware and differently-configured
> kernels.
> 
> So make the conditional inclusion of FCoE code in 8021q match the
> conditional inclusion in netdevice.h
> 
> Signed-off-by: Chris Leech <cleech@...hat.com>

Applied, thanks Chris.