netdev - Re: [PATCH net-next 1/1] net: sched: ensure tc flower reoffload takes filter ref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190404.172006.2092092064840910481.davem@davemloft.net>
Date:   Thu, 04 Apr 2019 17:20:06 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     john.hurley@...ronome.com
Cc:     jiri@...lanox.com, xiyou.wangcong@...il.com,
        netdev@...r.kernel.org, vladbu@...lanox.com,
        oss-drivers@...ronome.com
Subject: Re: [PATCH net-next 1/1] net: sched: ensure tc flower reoffload
 takes filter ref

From: John Hurley <john.hurley@...ronome.com>
Date: Tue,  2 Apr 2019 23:53:20 +0100

> Recent changes to TC flower remove the requirement for rtnl lock when
> accessing and modifying filters. Refcounts now ensure access and deletion
> do not happen concurrently. However, the reoffload function which cycles
> through all filters and replays them to registered hw drivers is not
> protected.
> 
> Use the fl_get_next_filter() function to cycle the filters for reoffload
> and ensure the ref taken by this function is put when done with each
> filter.
> 
> Signed-off-by: John Hurley <john.hurley@...ronome.com>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Applied, thank you.