netdev - Re: [PATCH iproute2-next] ip xfrm: support setting/printing XFRMA_IF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190406035732.7giilcz25yxgke5e@AntonyAntony.local>
Date:   Sat, 6 Apr 2019 05:57:33 +0200
From:   Antony Antony <antony@...nome.org>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     Eyal Birger <eyal.birger@...il.com>, netdev@...r.kernel.org,
        antony@...nome.org
Subject: Re: [PATCH iproute2-next] ip xfrm: support setting/printing
 XFRMA_IF_ID attribute in states/policies

On Fri, Apr 05, 2019 at 03:07:58PM -0700, Stephen Hemminger wrote:
> On Thu,  4 Apr 2019 19:07:38 +0300
> Eyal Birger <eyal.birger@...il.com> wrote:
> 
> > The XFRMA_IF_ID attribute is set in policies/states for them to be
> > associated with an XFRM interface (4.19+).
> > 
> > Add support for setting / displaying this attribute.
> > 
> > Note that 0 is a valid value therefore set XFRMA_IF_ID if any value
> > was provided in command line.
> > 
> > Tested-by: Antony Antony <antony@...nome.org>
> > Signed-off-by: Eyal Birger <eyal.birger@...il.com>
> 
> This is already handled by an earlier patch, that I just applied

Do you  mean commit 286446c1
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=286446c1e8c7f5f6eca4959015aa9e482b7adb11

Matt's patch is to support link.  
e.g ip link add ipsec0 type xfrm dev enp0s5 if_id 0xAB

Eyal's patch for xfrm state and policy.
e.g 
ip xfrm policy add src 10.1.1.200/32 dst 10.1.1.100/32 dir in tmpl src 
172.16.1.200 dst 172.16.1.100 proto esp reqid 2 mode tunnel if_id 10

Thanks for applying Matt's patch. We need for both patches.

-antony