lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 8 Apr 2019 00:13:12 +0200 From: Andrew Lunn <andrew@...n.ch> To: Heiner Kallweit <hkallweit1@...il.com> Cc: Florian Fainelli <f.fainelli@...il.com>, David Miller <davem@...emloft.net>, Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>, Richard Cochran <richardcochran@...il.com>, Kevin Hilman <khilman@...libre.com>, Heiko Stuebner <heiko@...ech.de>, bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-amlogic@...ts.infradead.org, linux-rockchip@...ts.infradead.org Subject: Re: [PATCH net-next] net: phy: switch drivers to use dynamic feature detection On Sun, Apr 07, 2019 at 11:57:13AM +0200, Heiner Kallweit wrote: > Recently genphy_read_abilities() has been added that dynamically detects > clause 22 PHY abilities. I *think* this detection should work with all > supported PHY's, at least for the ones with basic features sets, i.e. > PHY_BASIC_FEATURES and PHY_GBIT_FEATURES. So let's remove setting these > features explicitly and rely on phylib feature detection. Hi Heiner We could make this a two step process, to avoid regressions. For one cycle compare genphy_read_abilities() against .features and raise a WARN_ON() if they differ. And keep using the .features value. Then a release late, complete the swap removing .features and the WARN_ON. Andrew
Powered by blists - more mailing lists