lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 8 Apr 2019 00:13:12 +0200
From:   Andrew Lunn <>
To:     Heiner Kallweit <>
Cc:     Florian Fainelli <>,
        David Miller <>,
        Ray Jui <>,
        Scott Branden <>,
        Richard Cochran <>,
        Kevin Hilman <>,
        Heiko Stuebner <>,,,,,
Subject: Re: [PATCH net-next] net: phy: switch drivers to use dynamic feature

On Sun, Apr 07, 2019 at 11:57:13AM +0200, Heiner Kallweit wrote:
> Recently genphy_read_abilities() has been added that dynamically detects
> clause 22 PHY abilities. I *think* this detection should work with all
> supported PHY's, at least for the ones with basic features sets, i.e.
> PHY_BASIC_FEATURES and PHY_GBIT_FEATURES. So let's remove setting these
> features explicitly and rely on phylib feature detection.

Hi Heiner

We could make this a two step process, to avoid regressions. For one
cycle compare genphy_read_abilities() against .features and raise a
WARN_ON() if they differ. And keep using the .features value.

Then a release late, complete the swap removing .features and the


Powered by blists - more mailing lists