netdev - [PATCH v2 0/3] ethtool: fix use of SPEED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 Apr 2019 10:48:44 -0400
From:   Michael Zhivich <mzhivich@...mai.com>
To:     <davem@...emloft.net>
CC:     <siva.kallam@...adcom.com>, <prashant@...adcom.com>,
        <mchan@...adcom.com>, <shshaikh@...vell.com>,
        <manishc@...vell.com>, <netdev@...r.kernel.org>,
        Michael Zhivich <mzhivich@...mai.com>
Subject: [PATCH v2 0/3] ethtool: fix use of SPEED_UNKNOWN constant

This patch series addresses 2 related issues:

1. ethtool_validate_speed() triggers a "signed-unsigned comparison"
warning due to type difference of SPEED_UNKNOWN constant (int)
and argument to ethtool_validate_speed (__u32).

2. some drivers use u16 storage for SPEED_UNKNOWN constant, 
resulting in value truncation and thus failure to test against
SPEED_UNKNOWN correctly.

This revised series addresses several feedback comments:
- split up the patch in to series
- do not unnecessarily change drivers that use "int" storage
  for speed values

Michael Zhivich (3):
  ethtool: avoid signed-unsigned comparison in ethtool_validate_speed()
  broadcom: tg3: fix use of SPEED_UNKNOWN ethtool constant
  qlogic: qlcnic: fix use of SPEED_UNKNOWN ethtool constant

 drivers/net/ethernet/broadcom/tg3.c         | 8 ++++----
 drivers/net/ethernet/broadcom/tg3.h         | 4 ++--
 drivers/net/ethernet/qlogic/qlcnic/qlcnic.h | 2 +-
 include/uapi/linux/ethtool.h                | 2 +-
 4 files changed, 8 insertions(+), 8 deletions(-)

-- 
2.7.4