netdev - Re: [PATCH net] selftests: add a tc matchall test case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190407.193231.154740375748044068.davem@davemloft.net>
Date:   Sun, 07 Apr 2019 19:32:31 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     nicolas.dichtel@...nd.com
Cc:     jiri@...lanox.com, netdev@...r.kernel.org, bjb@...atatu.com,
        lucasb@...atatu.com, kleib@...atatu.com
Subject: Re: [PATCH net] selftests: add a tc matchall test case

From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
Date: Fri,  5 Apr 2019 14:20:24 +0200

> This is a follow up of the commit 0db6f8befc32 ("net/sched: fix ->get
> helper of the matchall cls").
> 
> To test it:
> $ cd tools/testing/selftests/tc-testing
> $ ln -s ../plugin-lib/nsPlugin.py plugins/20-nsPlugin.py
> $ ./tdc.py -n -e 2638
> 
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Applied, thanks Nicolas.

> I'm not sure to understand the goal of this series:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/?h=45b3a3762721
> 
> But after it, tc selftests are not intuitive anymore. When naively running them
> (./tdy.py), all fw filter tests fail. It's hard to understand that the problem
> is that they require the 'nsPlugin' plugin to be enabled (by adding a symlink
> *and* providing the '-n' option to tdc.py).
> 
> Brenda, why putting the netns code into a plugin that is disabled by default,
> knowing that this code is mandatory to run the test?

Brenda, please respond.