netdev - Re: [PATCH net] selftests: add a tc matchall test case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMDBHY+9Yme0cF8vP9_LnHF16BOyp2rtB51YjsYuMaV-WYYS4A@mail.gmail.com>
Date:   Mon, 8 Apr 2019 18:24:08 -0400
From:   Lucas Bates <lucasb@...atatu.com>
To:     David Miller <davem@...emloft.net>
Cc:     nicolas.dichtel@...nd.com, jiri@...lanox.com,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Brenda Butler <bjb@...atatu.com>,
        Keara Leibovitz <kleib@...atatu.com>
Subject: Re: [PATCH net] selftests: add a tc matchall test case

On Sun, Apr 7, 2019 at 10:32 PM David Miller <davem@...emloft.net> wrote:
> > I'm not sure to understand the goal of this series:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/?h=45b3a3762721
> >
> > But after it, tc selftests are not intuitive anymore. When naively running them
> > (./tdy.py), all fw filter tests fail. It's hard to understand that the problem
> > is that they require the 'nsPlugin' plugin to be enabled (by adding a symlink
> > *and* providing the '-n' option to tdc.py).
> >
> > Brenda, why putting the netns code into a plugin that is disabled by default,
> > knowing that this code is mandatory to run the test?
>
> Brenda, please respond.

This would be a documentation issue - the usage of nsPlugin is not
covered in the README.  I'll submit a patch by end of the day tomorrow
to address it.

The namespace code isn't mandatory, strictly speaking.  It's not
required at all when running the action tests, only with the filter
tests as those need a specific device to be attached to.

The actual problem is that the nsPlugin creates a veth pair using the
names found in the config file (DEV0/DEV1) - but if you aren't using
the plugin, then a port won't be created.  The intention is that you'd
create a port manually before starting the tests.