netdev - Re: [PATCH net] netdevice: Fix promiscuity and allmulti negative overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190408125005.GQ10051@dhcp-12-139.nay.redhat.com>
Date:   Mon, 8 Apr 2019 20:50:05 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, wangchen@...fujitsu.com, sbrivio@...hat.com
Subject: Re: [PATCH net] netdevice: Fix promiscuity and allmulti negative
 overflow

Hi David,
On Sat, Apr 06, 2019 at 06:14:28PM -0700, David Miller wrote:
> From: Hangbin Liu <liuhangbin@...il.com>
> Date: Thu,  4 Apr 2019 20:45:18 +0800
> 
> > Similarly to dad9b335c694 ("netdevice: Fix promiscuity and allmulti
> > overflow"), we should not decrease promiscuity if it is already 0.
> > 
> > An example is after adding a team interface to bridge, the team interface
> > will enter promisc mode. Then if we add a slave to team0, the slave will
> > keep promisc off. If we remove team from bridge, both team0 and slave will
> > decrease the promiscuity, which will cause a negative overflow on the slave.
> > The team's issue will be fixed in a separate patch.
> > 
> > Reviewed-by: Stefano Brivio <sbrivio@...hat.com>
> > Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> 
> These little hacks are endless.
> 
> I would rather see team and bridge and bonding appropriately keep the
> promisc count adjusted as need when slaves are added/removed etc.

Yes, I have post a v2 patch for team fix. but I think the
dev_set_promiscuity() should also be more robust and not broken
so eassily.

Thanks
Hangbin