netdev - Re: [PATCH net] netdevice: Fix promiscuity and allmulti negative overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190408125221.GR10051@dhcp-12-139.nay.redhat.com>
Date:   Mon, 8 Apr 2019 20:52:21 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org, Wang Chen <wangchen@...fujitsu.com>,
        David Miller <davem@...emloft.net>,
        Stefano Brivio <sbrivio@...hat.com>
Subject: Re: [PATCH net] netdevice: Fix promiscuity and allmulti negative
 overflow

On Sun, Apr 07, 2019 at 08:43:24AM -0700, Stephen Hemminger wrote:
> On Thu,  4 Apr 2019 20:45:18 +0800
> Hangbin Liu <liuhangbin@...il.com> wrote:
> 
> > Similarly to dad9b335c694 ("netdevice: Fix promiscuity and allmulti
> > overflow"), we should not decrease promiscuity if it is already 0.
> 
> This should never happen. If it is a kernel bug and should be reported
> like refcnt_t overflow.

Hi Stephen,

The type of promiscuity and allmulti is 'unsigned int'. That why it happened.

Thanks
Hangbin