[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <3a49a296-a552-0870-7cdf-2c6d5f991d10@6wind.com>
Date: Tue, 9 Apr 2019 17:29:16 +0200
From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
To: David Miller <davem@...emloft.net>, lucasb@...atatu.com
Cc: jiri@...lanox.com, netdev@...r.kernel.org, bjb@...atatu.com,
kleib@...atatu.com
Subject: Re: [PATCH net] selftests: add a tc matchall test case
Le 09/04/2019 à 00:45, David Miller a écrit :
> From: Lucas Bates <lucasb@...atatu.com>
[snip]
>> This would be a documentation issue - the usage of nsPlugin is not
>> covered in the README. I'll submit a patch by end of the day tomorrow
>> to address it.
>>
>> The namespace code isn't mandatory, strictly speaking. It's not
>> required at all when running the action tests, only with the filter
>> tests as those need a specific device to be attached to.
>>
>> The actual problem is that the nsPlugin creates a veth pair using the
>> names found in the config file (DEV0/DEV1) - but if you aren't using
>> the plugin, then a port won't be created. The intention is that you'd
>> create a port manually before starting the tests.
>
> That's poor behavior.
>
> If I just want to run all the tests, I should be able to just execute
> the script with no special arguments.
+1
If we want that people use those kind of tests, it must work without any operations.
Regards,
Nicolas
Powered by blists - more mailing lists