netdev - Re: [v2] net: xilinx: add a helper function for axienet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cb5657c0-e21a-0228-0638-0b41b423a812@web.de>
Date:   Wed, 10 Apr 2019 11:20:13 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Wen Yang <wen.yang99@....com.cn>, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Cc:     linux-kernel@...r.kernel.org, Yi Wang <wang.yi59@....com.cn>,
        Anirudha Sarangi <anirudh@...inx.com>,
        John Linn <John.Linn@...inx.com>,
        "David S. Miller" <davem@...emloft.net>,
        Michal Simek <michal.simek@...inx.com>
Subject: Re: [v2] net: xilinx: add a helper function for axienet_probe

> The "Find DMA Node, Map DMA Register, and Decode DMA IRQ" code snippets
> in axienet_probe() are independent. Tidy this function implementation
> a little up by factoring these calls out into a helper function.

Would another adjustment be safer for the word “independent”
because there are dependencies usually involved between function calls
for such a software refactoring?


> v2: Massaged changelog a bit

Thanks.

Regards,
Markus