lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190411150432.72882c56@carbon>
Date:   Thu, 11 Apr 2019 15:04:32 +0200
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     Matteo Croce <mcroce@...hat.com>
Cc:     netdev@...r.kernel.org, Sunil Goutham <sgoutham@...ium.com>,
        Robert Richter <rric@...nel.org>,
        linux-arm-kernel@...ts.infradead.org,
        Ilias Apalodimas <ilias.apalodimas@...aro.org>,
        David Miller <davem@...emloft.net>, brouer@...hat.com
Subject: Re: [PATCH v3 1/2] net: thunderx: raise XDP MTU to 1508

On Thu, 11 Apr 2019 12:26:32 +0200
Matteo Croce <mcroce@...hat.com> wrote:

> The thunderx driver splits frames bigger than 1530 bytes to multiple
> pages, making impossible to run an eBPF program on it.
> This leads to a maximum MTU of 1508 if QinQ is in use.
> 
> The thunderx driver forbids to load an eBPF program if the MTU is higher
> than 1500 bytes. Raise the limit to 1508 so it is possible to use L2
> protocols which need some more headroom.
> 
> Fixes: 05c773f52b96e ("net: thunderx: Add basic XDP support")
> Signed-off-by: Matteo Croce <mcroce@...hat.com>
> ---
>  drivers/net/ethernet/cavium/thunder/nicvf_main.c | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)

LGTM

Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ