netdev - Re: [PATCH v3 2/2] net: thunderx: don't allow jumbo frames with XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190411150504.2be998aa@carbon>
Date:   Thu, 11 Apr 2019 15:05:04 +0200
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     Matteo Croce <mcroce@...hat.com>
Cc:     netdev@...r.kernel.org, Sunil Goutham <sgoutham@...ium.com>,
        Robert Richter <rric@...nel.org>,
        linux-arm-kernel@...ts.infradead.org,
        Ilias Apalodimas <ilias.apalodimas@...aro.org>,
        David Miller <davem@...emloft.net>, brouer@...hat.com
Subject: Re: [PATCH v3 2/2] net: thunderx: don't allow jumbo frames with XDP

On Thu, 11 Apr 2019 12:26:33 +0200
Matteo Croce <mcroce@...hat.com> wrote:

> The thunderx driver forbids to load an eBPF program if the MTU is too high,
> but this can be circumvented by loading the eBPF, then raising the MTU.
> 
> Fix this by limiting the MTU if an eBPF program is already loaded.
> 
> Fixes: 05c773f52b96e ("net: thunderx: Add basic XDP support")
> Signed-off-by: Matteo Croce <mcroce@...hat.com>

LGTM

Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer