netdev - Re: [PATCH] ip6_tunnel: Match to ARPHRD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190411.141559.1811132902127795161.davem@davemloft.net>
Date:   Thu, 11 Apr 2019 14:15:59 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     sheena.mira-ato@...iedtelesis.co.nz
Cc:     netdev@...r.kernel.org, kuznet@....inr.ac.ru,
        yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH] ip6_tunnel: Match to ARPHRD_TUNNEL6 for dev type

From: Sheena Mira-ato <sheena.mira-ato@...iedtelesis.co.nz>
Date: Wed, 10 Apr 2019 08:36:35 +1200

> The device type for ip6 tunnels is set to
> ARPHRD_TUNNEL6. However, the ip4ip6_err function
> is expecting the device type of the tunnel to be
> ARPHRD_TUNNEL.  Since the device types do not
> match, the function exits and the ICMP error
> packet is not sent to the originating host. Note
> that the device type for IPv4 tunnels is set to
> ARPHRD_TUNNEL.
> 
> Fix is to expect a tunnel device type of
> ARPHRD_TUNNEL6 instead.  Now the tunnel device
> type matches and the ICMP error packet is sent
> to the originating host.
> 
> Signed-off-by: Sheena Mira-ato <sheena.mira-ato@...iedtelesis.co.nz>

This change is already in my tree, why are you resubmitting it?