netdev - Re: [PATCH] ip6_tunnel: Match to ARPHRD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1555021748.11406.2.camel@alliedtelesis.co.nz>
Date:   Thu, 11 Apr 2019 22:29:08 +0000
From:   Sheena Mira-ato <Sheena.Mira-ato@...iedtelesis.co.nz>
To:     "davem@...emloft.net" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "yoshfuji@...ux-ipv6.org" <yoshfuji@...ux-ipv6.org>,
        "kuznet@....inr.ac.ru" <kuznet@....inr.ac.ru>
Subject: Re: [PATCH] ip6_tunnel: Match to ARPHRD_TUNNEL6 for dev type

Sorry about this.

I resubmitted it, then a day later got the emails informing me
that the patch was added to the 4.19-stable and 5.0-stable trees.

Thanks
Sheena
On Thu, 2019-04-11 at 14:15 -0700, David Miller wrote:
> From: Sheena Mira-ato <sheena.mira-ato@...iedtelesis.co.nz>
> Date: Wed, 10 Apr 2019 08:36:35 +1200
> 
> > 
> > The device type for ip6 tunnels is set to
> > ARPHRD_TUNNEL6. However, the ip4ip6_err function
> > is expecting the device type of the tunnel to be
> > ARPHRD_TUNNEL.  Since the device types do not
> > match, the function exits and the ICMP error
> > packet is not sent to the originating host. Note
> > that the device type for IPv4 tunnels is set to
> > ARPHRD_TUNNEL.
> > 
> > Fix is to expect a tunnel device type of
> > ARPHRD_TUNNEL6 instead.  Now the tunnel device
> > type matches and the ICMP error packet is sent
> > to the originating host.
> > 
> > Signed-off-by: Sheena Mira-ato <sheena.mira-ato@...iedtelesis.co.nz>
> This change is already in my tree, why are you resubmitting it?