netdev - Re: [PATCH net-next 0/2] net: phy: shrink PHY settings array and add 200Gbps support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8c3f4be5-823a-5183-08ff-e34c3f91035d@gmail.com>
Date:   Sat, 13 Apr 2019 19:26:58 +0200
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 0/2] net: phy: shrink PHY settings array and add
 200Gbps support

On 13.04.2019 19:07, Andrew Lunn wrote:
> On Sat, Apr 13, 2019 at 06:51:16PM +0200, Heiner Kallweit wrote:
>> The definition of array settings[] is quite lengthy meanwhile. Add a
>> macro to shrink the definition.
>>
>> When doing this I saw that the new 200Gbps modes aren't supported
>> in phylib yet. So add this. I think we need to document somewhere
>> which places in phylib need to be touched if a new speed / mode is
>> added.
> 
> Yes, maybe something like
> 
> BUILD_BUG_ON(__ETHTOOL_LINK_MODE_MASK_NBITS != 67);
> 
> in drivers/net/phy/phy-core.c with a comment explaining what should be
> done?
> 
Yes, this sounds reasonable. We could use BUILD_BUG_ON_MSG to print
this comment.

> 	Andrew
> 
Heiner