netdev - Re: [PATCH net-next 1/2] net: phy: shrink PHY settings array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3701cb5f-a618-eb1e-34b8-93b58beae985@gmail.com>
Date:   Sat, 13 Apr 2019 19:28:43 +0200
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/2] net: phy: shrink PHY settings array

On 13.04.2019 19:14, Andrew Lunn wrote:
>> +	PHY_SETTING( 100000, FULL, 100000baseCR4_Full		),
>> +	PHY_SETTING( 100000, FULL, 100000baseKR4_Full		),
>> +	PHY_SETTING( 100000, FULL, 100000baseLR4_ER4_Full	),
>> +	PHY_SETTING( 100000, FULL, 100000baseSR4_Full		),
>> +	PHY_SETTING(  56000, FULL,  56000baseCR4_Full	  	),
>> +	PHY_SETTING(  56000, FULL,  56000baseKR4_Full	  	),
>> +	PHY_SETTING(  56000, FULL,  56000baseLR4_Full	  	),
>> +	PHY_SETTING(  56000, FULL,  56000baseSR4_Full	  	),
>> +	PHY_SETTING(  50000, FULL,  50000baseCR2_Full		),
>> +	PHY_SETTING(  50000, FULL,  50000baseKR2_Full		),
>> +	PHY_SETTING(  50000, FULL,  50000baseSR2_Full		),
>> +	PHY_SETTING(  40000, FULL,  40000baseCR4_Full		),
>> +	PHY_SETTING(  40000, FULL,  40000baseKR4_Full		),
>> +	PHY_SETTING(  40000, FULL,  40000baseLR4_Full		),
>> +	PHY_SETTING(  40000, FULL,  40000baseSR4_Full		),
>> +	PHY_SETTING(  20000, FULL,  20000baseKR2_Full		),
>> +	PHY_SETTING(  20000, FULL,  20000baseMLD2_Full		),
>> +	PHY_SETTING(  10000, FULL,  10000baseCR_Full		),
>> +	PHY_SETTING(  10000, FULL,  10000baseER_Full		),
>> +	PHY_SETTING(  10000, FULL,  10000baseKR_Full		),
>> +	PHY_SETTING(  10000, FULL,  10000baseKX4_Full		),
>> +	PHY_SETTING(  10000, FULL,  10000baseLR_Full		),
>> +	PHY_SETTING(  10000, FULL,  10000baseLRM_Full		),
>> +	PHY_SETTING(  10000, FULL,  10000baseR_FEC		),
>> +	PHY_SETTING(  10000, FULL,  10000baseSR_Full		),
>> +	PHY_SETTING(  10000, FULL,  10000baseT_Full		),
>> +	PHY_SETTING(   2500, FULL,  2500baseT_Full		),
>> +	PHY_SETTING(   2500, FULL,  2500baseX_Full		),
>> +	PHY_SETTING(   1000, FULL,  1000baseKX_Full		),
>> +	PHY_SETTING(   1000, FULL,  1000baseT_Full		),
>> +	PHY_SETTING(   1000, HALF,  1000baseT_Half		),
>> +	PHY_SETTING(   1000, FULL,  1000baseX_Full		),
>> +	PHY_SETTING(    100, FULL,   100baseT_Full		),
>> +	PHY_SETTING(    100, HALF,   100baseT_Half		),
>> +	PHY_SETTING(     10, FULL,    10baseT_Full		),
>> +	PHY_SETTING(     10, HALF,    10baseT_Half		),
> 
> I like the spaces here for the speed. I know i've missed counted the
> number of 0 and put entries in the wrong place. Maybe 2500base* and
> later could be indented by one more space, so that 'base' is always in
> the same column?
> 
Indeed, one space is missing for the modes <= 2500.

>     Andrew
> 
Heiner